Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add & remove ansible role #14556

Merged
merged 2 commits into from
Apr 18, 2024
Merged

add & remove ansible role #14556

merged 2 commits into from
Apr 18, 2024

Conversation

amolpati30
Copy link
Contributor

@amolpati30 amolpati30 commented Mar 28, 2024 •
edited
Loading

Problem Statement

Ansible role should be added and removed for new_ui host

Solution

Added test coverage to resolve above problem statement

Additional info

Removed test_positive_assign_role_in_new_ui , because single test case is covering add and remove scenario.

Dependent PR: SatelliteQE/airgun#1347

@amolpati30 amolpati30 requested a review from a team as a code owner March 28, 2024 11:48
@amolpati30 amolpati30 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Mar 28, 2024
@amolpati30 amolpati30 mentioned this pull request Mar 28, 2024
Merged
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py -k test_positive_add_and_remove_ansible_role_in_new_ui
airgun: 1300

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6244
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_ansible.py -k test_positive_add_and_remove_ansible_role_in_new_ui --external-logging
Test Result : =========== 1 failed, 8 deselected, 7 warnings in 833.57s (0:13:53) ============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 28, 2024
@Satellite-QE Satellite-QE removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 28, 2024
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py -k test_positive_add_and_remove_ansible_role_in_new_ui
airgun: 1300

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6247
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py -k test_positive_add_and_remove_ansible_role_in_new_ui --external-logging
Test Result : =========== 1 passed, 8 deselected, 9 warnings in 820.05s (0:13:40) ============

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 28, 2024
Griffin-Sullivan
Griffin-Sullivan approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me need to wait for airgun

vijaysawant
vijaysawant requested changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we remove step 1 as well, as we are not using function_host.register() method anywhere in test module?

synkd
synkd reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@synkd synkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but please do change adding the role tot he host from an API call to a UI action.

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 3, 2024
@amolpati30 amolpati30 force-pushed the ansibleRemoveRole branch 2 times, most recently from 22c0a39 to 7e28915 Compare April 3, 2024 10:14
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py -k test_positive_assign_and_remove_ansible_role_in_new_ui
airgun: 1300

@amolpati30 amolpati30 force-pushed the ansibleRemoveRole branch 2 times, most recently from 0e99a23 to 16278e5 Compare April 3, 2024 10:51
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6283
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py -k test_positive_assign_and_remove_ansible_role_in_new_ui --external-logging
Test Result : =========== 1 passed, 8 deselected, 10 warnings in 746.45s (0:12:26) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 3, 2024
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py -k test_positive_assign_and_remove_ansible_role_in_new_ui
airgun: 1300

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6317
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py -k test_positive_assign_and_remove_ansible_role_in_new_ui --external-logging
Test Result : =========== 1 passed, 9 deselected, 10 warnings in 858.38s (0:14:18) ===========

@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt -k test_positive_assign_and_remove_ansible_role_to_host
airgun: 1347

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6549
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt -k test_positive_assign_and_remove_ansible_role_to_host --external-logging
Test Result : ========== 1 passed, 14 deselected, 29 warnings in 747.05s (0:12:27) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Apr 17, 2024
This was referenced Apr 17, 2024
Merged
Merged
vijaysawant
vijaysawant approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack
Non-blocking: Please confirm step 1 which says 'Register a RHEL host to a Satellite', is it part of setup or steps? shift to new section or remove that.

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 18, 2024
@amolpati30
Copy link
Contributor Author

pre-commit.ci autofix

@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt -k test_positive_assign_and_remove_ansible_role_to_host
airgun: 1347

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6591
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt -k test_positive_assign_and_remove_ansible_role_to_host --external-logging
Test Result : ========== 1 passed, 14 deselected, 29 warnings in 839.07s (0:13:59) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 18, 2024
@omkarkhatavkar omkarkhatavkar merged commit 2d915bc into SatelliteQE:master Apr 18, 2024
9 of 10 checks passed
@Satellite-QE Satellite-QE mentioned this pull request Apr 18, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Apr 18, 2024
@amolpati30 @web-flow
add & remove ansible role (#14556)
999b4a5 
* add remove ansible role from host

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 2d915bc)
github-actions bot pushed a commit that referenced this pull request Apr 18, 2024
@amolpati30 @web-flow
add & remove ansible role (#14556)
a7e0704 
* add remove ansible role from host

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 2d915bc)
@Satellite-QE Satellite-QE mentioned this pull request Apr 18, 2024
Merged
@amolpati30 amolpati30 mentioned this pull request Aug 20, 2024
Merged
This was referenced Aug 21, 2024
Merged
Merged
Merged
Merged
This was referenced Aug 27, 2024
Merged
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@amolpati30 @pre-commit-ci @jyejare
add & remove ansible role (SatelliteQE#14556)
b3b8421 
* add remove ansible role from host

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omkarkhatavkar omkarkhatavkar omkarkhatavkar approved these changes

@vijaysawant vijaysawant vijaysawant approved these changes

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

@synkd synkd Awaiting requested review from synkd

@Gauravtalreja1 Gauravtalreja1 Awaiting requested review from Gauravtalreja1

Assignees

@amolpati30 amolpati30

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@amolpati30 @Satellite-QE @Gauravtalreja1 @omkarkhatavkar @vijaysawant @synkd @Griffin-Sullivan